Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double-clicking a thumbnail to make image fullscreen immediately switches to the next image #1396

Open
HolyBlackCat opened this issue Jun 14, 2024 · 3 comments
Labels

Comments

@HolyBlackCat
Copy link

Setup (please complete the following information):

  • Distribution: Arch
  • Distribution release: 🙃
  • Geeqie version [geeqie --version]: Geeqie 2.4 GTK3

Describe the bug

Double-clicking a thumbnail is supposed to open that image fullscreen. It does that, but it also immediately switches to the next image.

If you click slowly, you can see that pressing the mouse the second time opens the fullscreen, and then releasing it switches the image.

To reproduce
Steps to reproduce the behavior:

  • Double-click a specific image thumbnail.
  • Observe the immediate switch to the next image.

Expected behavior
Double-clicking a thumbnail should just open that image fullscreen, and not switch to the next one.

@caclark
Copy link
Collaborator

caclark commented Jun 14, 2024

I think this is because of an option that causes a confliction.

Go to Edit/Preferences/Behaviour and unset Navigation By Left Or Middle Click On Image

@caclark caclark closed this as completed Jun 14, 2024
@HolyBlackCat
Copy link
Author

HolyBlackCat commented Jun 14, 2024

@caclark But I do want the left-click to switch to the next image. It just must not happen when first opening fullscreen. If the option exists in the first place, it should work correctly.

Moreover, I think I'm using the default settings (but I could be wrong here).

@caclark caclark reopened this Jun 14, 2024
@caclark
Copy link
Collaborator

caclark commented Jun 14, 2024

The problem exists because the project has evolved, rather than being a from-scratch consistent design.
The click-for-next-image came first, and the double-click for full-screen came next.

The solution is to delay processing of a single click until the double-click time has elapsed. That is possible, but is not so trivial because the code in that section would no longer be linear. If the user has set a long double-click time, they will see that delay before the next image is displayed.

Until it is fixed the mouse-only possibilities are to unset Navigation By Left Or Middle Click On Image and use the mouse wheel to move next/previous image, or use the right-click menu.

Moreover, I think I'm using the default settings (but I could be wrong here).

Yes, that is true. When the click-for-next-image code was implemented, it was set as the default. I did not want to change default settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants