Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Won't try using exiv2 #1592

Open
TomK32 opened this issue Jan 10, 2025 · 1 comment
Open

Won't try using exiv2 #1592

TomK32 opened this issue Jan 10, 2025 · 1 comment
Labels

Comments

@TomK32
Copy link
Contributor

TomK32 commented Jan 10, 2025

The arch package lists exiv2 (which installs /usr/bin/exiv2) as a dependency but not perl-image-exiftool which installs the /usr/bin/vendor_perl/exiftool. I only tried the crop function so far, simply by creating a symlink from /usr/bin/exiv2 to /usr/bin/exiftool (I realized that the perl package was missing only later) and it worked fine.

I don't know how compatible exiv2 and exiftool are in functionality and arguments (I will find out though), but would it be possible for geeqie to make it configurable which of both to use or simply try for both?

@TomK32 TomK32 added the bug label Jan 10, 2025
@caclark
Copy link
Collaborator

caclark commented Jan 10, 2025

I only tried the crop function so far, simply by creating a symlink from /usr/bin/exiv2 to /usr/bin/exiftool

Unfortunately that will not work.

The relevant file is ./plugins/image-crop/geeqie-image-crop.sh

The comment shows Requires ImageMagick and exiftool. That is incorrect.
The comment should be Requires ImageMagick, exiftool and exiv2.
The code should be updated for a check for the existence exiv2

You will see that exiftool is used to read the orientation tag and set it in the extracted file.
The script could be changed to use exiv2 for that, thus eliminating the need for exiftool.
[I probably used exiftool because I happened to know the correct syntax, or I copied it from somewhere else...]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants