From 1311d65c88a2f40a15e49e9f1092ff8660049269 Mon Sep 17 00:00:00 2001 From: Maya Jones Date: Thu, 23 Aug 2018 12:08:33 -0400 Subject: [PATCH 1/2] Allows hidden to work in shadow dom. --- d2l-button-icon.html | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/d2l-button-icon.html b/d2l-button-icon.html index e13aaea..af08f13 100644 --- a/d2l-button-icon.html +++ b/d2l-button-icon.html @@ -27,6 +27,10 @@ right: calc(((var(--d2l-button-icon-min-width) - 0.9rem) / 2) * -1); } } + :host([hidden]) { + display: none; + } + button { background-color: transparent; border-color: transparent; From 16989e67fdfd8265d7cc6273a5688c62bb9491bc Mon Sep 17 00:00:00 2001 From: Maya Jones Date: Fri, 24 Aug 2018 08:50:59 -0400 Subject: [PATCH 2/2] Updated tests. I added display none to the other elements. --- d2l-button.html | 3 +++ d2l-floating-buttons.html | 3 +++ wct.conf.json | 4 ++-- 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/d2l-button.html b/d2l-button.html index cde5ad8..73bce14 100644 --- a/d2l-button.html +++ b/d2l-button.html @@ -18,6 +18,9 @@ :host { display: inline-block; } + :host([hidden]) { + display: none; + } button { font-family: inherit; padding: 0.5rem 1.5rem; diff --git a/d2l-floating-buttons.html b/d2l-floating-buttons.html index a3689e2..dd5a3f6 100644 --- a/d2l-floating-buttons.html +++ b/d2l-floating-buttons.html @@ -17,6 +17,9 @@ box-sizing: border-box; display: block; } + :host([hidden]) { + display: none; + } .d2l-floating-buttons-container { border-top: 1px solid transparent; display: block; diff --git a/wct.conf.json b/wct.conf.json index f8a730d..7c693ab 100644 --- a/wct.conf.json +++ b/wct.conf.json @@ -14,12 +14,12 @@ "browsers": [ { "browserName": "chrome", - "platform": "OS X 10.12", + "platform": "OS X 10.13", "version": "" }, { "browserName": "firefox", - "platform": "OS X 10.12", + "platform": "OS X 10.13", "version": "" }, {