Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving output fails for some problems #279

Closed
jpmorgan98 opened this issue Jan 24, 2025 · 2 comments
Closed

Saving output fails for some problems #279

jpmorgan98 opened this issue Jan 24, 2025 · 2 comments
Assignees
Labels
bug Something isn't working as intended

Comments

@jpmorgan98
Copy link
Collaborator

Reported for Kobyashi type problems including one from the challenge problem. @melekderman reports this happening in the profiler in pure Python mode. I have seen it in Numba (CPU and GPU) with and without MPI on various systems including Dane and Lassen. @alexandermote reported a similar error when there are multiple tallies when doing domain decomposition but any soultion has evaded us. This is happening on v0.11.1 and current dev. Example of an error report

  __  __  ____  __ ____   ____ 
 |  \/  |/ ___|/ /_  _ \ / ___|
 | |\/| | |   /_  / | | | |    
 | |  | | |___ / /| |_| | |___ 
 |_|  |_|\____|// |____/ \____|

           Mode | Numba
      Algorithm | History-based
  MPI Processes | 4
 OpenMP Threads | 1
 Now running TNT...

 Generating output HDF5 files...
Traceback (most recent call last):
  File "/usr/WS1/morgan83/pp-mcdc/kobyashi/highfidelity/input_hf.py", line 78, in <module>
    mcdc.run()
  File "/usr/workspace/morgan83/conda_lassen/envs/prod/lib/python3.12/site-packages/mcdc/main.py", line 91, in run
    generate_hdf5(data, mcdc)
  File "/usr/workspace/morgan83/conda_lassen/envs/prod/lib/python3.12/site-packages/mcdc/main.py", line 1306, in generate_hdf5
    tally_bin = tally_bin.reshape(shape)
                ^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: cannot reshape array of size 60 into shape (3,1,1,1,20,60,100,1,1)
@jpmorgan98 jpmorgan98 added the bug Something isn't working as intended label Jan 24, 2025
@jpmorgan98
Copy link
Collaborator Author

@melekderman reported that fetching changes from the upstream repo solved the issue

@ilhamv
Copy link
Member

ilhamv commented Jan 24, 2025

This is possibly due to the tally decomposition and recomposition, which are already fixed.

cc: @alexandermote

@ilhamv ilhamv closed this as completed Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as intended
Projects
None yet
Development

No branches or pull requests

3 participants