Windows : No gif created #1
Comments
|
The same thing for me, I put the .lua file in |
|
Hi, thanks for information! I'll check on a Windows machine and get back to you, it's probably an issue with path generation |
|
Okay, fixed and tested, works for me. Still doesn't work if there is [, ], + or - in the input or output path, working on that. |
|
Hi, it still doesn't work for me. Am I doing something wrong or what? |
|
@TheGr0ke are you using the latest vlc_gif_maker.lua from the repository? I didn't publish a new version yet, gonna do it later today after fixing the characters mentioned above. |
|
main debug: toggling pause |
|
@TheGr0ke thanks, you're affected by the special characters issue I'm still working on, certain characters in the file or folder name cause the command to be cut. For temporary solution, you could rename the movie file to a simpler name, should work until I fix it. Care to share the filename of the input video you're trying to use? |
|
the file name is "you are not immune to kaguya dub_Trim" |
|
i checked for myself and it's caused by spaces existing in filename |
|
@TheGr0ke that was it, thank you! Space was actually the first character I fixed so I didn't even suspect it, turns out I removed the fix at some point of debugging. @MyNameIsTroll @astrofr: I just released latest version (0.0.5), it should all work now! Let me know if it's fixed |
|
@Dante383 I'm sorry to tell you but the issue with space is still the same |
|
I was able to create my first gif with the extension. But in fact for some videos it is impossible. I don't know why. It must depend on the codec. I tested the extension on 5 videos and the extension worked on only one. |
|
At first wanted to thank you guys for creating GitHub (seemingly) just to inform me of the issue. Appreciate it, trying to return the favor by fixing Windows schenigans. Gotta admit, I didn't even test it on Windows, I assumed just switching from (/) to (\) in file paths would be enough, but apparently Microsoft must've felt the need for some 1985 Windows 1.0.1 compatibility or something and it requires special treatment. @TheGr0ke can confirm, which is really weird because I specifically tested it with spaces before pushing it to the repository. I just downloaded the latest version on my Windows machine and can confirm it's not working, despite the code being identical. I'm feeling pretty puzzled, I'm gonna tackle this later this week after sorting out work stuff. @astrofr are you sure it depends on the codec, not the filename? Whole path matters, so this issue with space will still be present if the file doesn't contain any spaces, but one of the folders above it does contain a space. (or some really weird special character). Not sure if ffmpeg does stuff differently on Windows, but you can check yourself. Here's the default extension command:
I already pre-filled everything, replace |
|
The same thing, in VLC it says that the file has been created, nothing is in place. Windows 10 |
Thank you for this. I was able to successfully create gifs using this command, however the actual VLC GIF Maker extension you've developed doesn't work at all. To be fair I haven't tried it on many different files, but the fact that it worked with your FFMPEG line of code but not within the actual VLC App with the extension running is very odd. Hopefully this is something you'll be able to fix, since running the code manually is a bit tiresome. I should note I am having the same issues as others, I click "create gif", then it says success, but nothing actually happens. It almost feels like no command is even being attempted to run in the background that's how quick it fails. If you have any questions about my paths/setup that could help you identify the problem please let me know. |
|
The same thing, in VLC it says that the file has been created, nothing is in place. Windows 10 |
|
The Get buttons sometimes acquire a |
Oh man, it's still causing issues? Thanks for reaching out. I have limited time right now but if you could;
The best thing you could do for me is copy the command from the Messages window and paste it into cmd.exe/Powershell so it'll tell where it hurts exactly
Greater by how much? Are we talking sub-second? There's some very basic time conversion in place but other than that, the value comes directly from VLC's current point in the video so I might not be able to do much about that |
|
@Dante383, thanks for your great script - it helps me a lot to make video notes. I'm not sure if that's the problem - but on linux spaces from vlc.input.item():uri() being encoded as "%20" ffmeg encloses the file path in " " - and the path breaks.
The same may apply to the output path. Also, I would guess that ffmeg's different versions does not always work correctly with the format "0:1:4:444", the leadership requirement is zero. |
|
Hi, thanks for your input!
Sadly I have no idea and "it works for me". Due to extremely limited time I cannot investigate this right now but I'll gladly accept a pull request if you feel like chasing the issue
…-------- Original Message --------
On 9/7/24 17:01, Lushnikov Stanislav wrote:
***@***.***(https://github.com/Dante383), thanks for your great script - it helps me a lot to make video notes.
I'm not sure if that's the problem - but on linux I've saw:
Spaces from vlc.input.item():uri() being encoded as "%20"
ffmeg encloses the file path in " " - and the path breaks.
Does it make sense to add a space-filled string to the generateCommand function?
command = string_replace(command, "%20", " ")
The same may apply to the output path
—
Reply to this email directly, [view it on GitHub](#1 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/ABQH7KZQCVARIHUDME2E7U3ZVMIMJAVCNFSM6AAAAABJ4RZLAOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZVGM3DMNZYGU).
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
I can not directly reproduce. The script works for me and my videos/gif. But reading the following
a bell ringed and I could imagine the following: If you download the LUA file from GitHub with "download raw file" the line ending is "LF". If you copy and paste the script from "raw" view in the browser, you get "CRLF". I do that sometimes if I don't need the repo. Or if I changed the file and want to go back to the repo version. Anyway: Git in its default config will set the line ending to the system default on a commit. I don't know how "LF/CRLF"-sensitive LUA is. And if it even matters. |
Hello,
It's the first time I've tried a VLC extension.
I'm on Windows and it doesn't work.
I've ffmpeg.
I have the menu with plugin but I have no VLC confirmation when I press Generate GIF.
I have nothing, my folder is empty.
Thank you so much.
The text was updated successfully, but these errors were encountered: