Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement validateAddress call so we don't need to call rpc of Doichain node for it. #136

Open
silkroadnomad opened this issue Feb 28, 2020 · 2 comments
Labels
B priority bounty make money enhancement New feature or request

Comments

@silkroadnomad
Copy link
Collaborator

silkroadnomad commented Feb 28, 2020

See: bitcoinjs/bitcoinjs-lib#890

@silkroadnomad silkroadnomad added enhancement New feature or request bounty make money labels Feb 28, 2020
@silkroadnomad silkroadnomad changed the title Improve validateAddress call so we don't need to call rpc call Implement validateAddress call so we don't need to call rpc of Doichain node for it. Feb 28, 2020
@silkroadnomad
Copy link
Collaborator Author

@silkroadnomad
Copy link
Collaborator Author

silkroadnomad commented Jun 13, 2020

necessity to check

  • valid (true/false)
  • ownAddress (true/false)
  • watchOnly (true/false)

We can only check this, if we have at least our publicKeys in a database. But also in this case a network call is necessary.
The latency improvement is maybe not as significant. Except we keep all our addresses and publicKeys in memory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B priority bounty make money enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant