Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce docker images size of doichain/dapp #141

Open
silkroadnomad opened this issue Mar 13, 2020 · 4 comments
Open

Reduce docker images size of doichain/dapp #141

silkroadnomad opened this issue Mar 13, 2020 · 4 comments
Labels
B priority bounty make money enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed security text & doc All text, documentation, translation works

Comments

@silkroadnomad
Copy link
Collaborator

silkroadnomad commented Mar 13, 2020 •
edited
Loading

Based of the analyzis of #139
please create new improved Dockerfile in order to reduce the docker image size.
Please use branch 0.0.9!
@silkroadnomad silkroadnomad added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers security bounty make money text & doc All text, documentation, translation works labels Mar 13, 2020
@jay-dee7
Copy link
Contributor

jay-dee7 commented Mar 14, 2020 •
edited
Loading

hey @inspiraluna i think it would be safe to remove the doichain-core source code related directory after the build process is done?
i'm refering to this content after make install since after make, the compiled code goes in /usr/local/bin/ and we don't really need the source at all:
Screenshot 2020-03-14 at 3 07 16 PM

@silkroadnomad
Copy link
Collaborator Author

silkroadnomad commented Mar 14, 2020 via email •
edited
Loading

@jay-dee7
Copy link
Contributor

@inspiraluna i tried removing it, however it didn't help much with reducing the size at all. It's taking longer than what i anticipated :(

@jay-dee7
Copy link
Contributor

jay-dee7 commented Mar 16, 2020 •
edited
Loading

@inspiraluna i've created a new PR here --> added alpine docker image, which reduces the size of the docker image from 1.7GB to 968MB. I have also added a doc, which explains about how to build the alpine image and also how to run the resulting image --> how to guide for alpine image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B priority bounty make money enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed security text & doc All text, documentation, translation works
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@silkroadnomad @jay-dee7