Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: more consistent mod dependency behavior #3991

Open
2 tasks done
cyn0x8 opened this issue Jan 12, 2025 · 1 comment
Open
2 tasks done

Enhancement: more consistent mod dependency behavior #3991

cyn0x8 opened this issue Jan 12, 2025 · 1 comment
Labels
status: planned Planned to be implemented some time in the future. topic: mods Related to the creation or use of mods. type: enhancement Involves an enhancement or new feature.

Comments

@cyn0x8
Copy link
Contributor

cyn0x8 commented Jan 12, 2025

Issue Checklist

  • I have properly named my enhancement
  • I have checked the Issues/Discussions pages to see if my enhancement has already been suggested

What is your suggestion, and why should it be implemented?

2 suggestions:

  • check mod dependency based on the mod title property (or better yet a new separate id property) in their _polymod_meta.json files and not the mod folder names (gamebanana adds hashes to filenames to prevent name collisions on their end, but because the dependency system currently checks based on folder name this can cause issues if the player doesnt know to rename it)
  • only unload the problematic mod instead of all mods when a dependency error occurs
@cyn0x8 cyn0x8 added status: pending triage Awaiting review. type: enhancement Involves an enhancement or new feature. labels Jan 12, 2025
@Hundrec Hundrec added the topic: mods Related to the creation or use of mods. label Jan 22, 2025
@EliteMasterEric
Copy link
Member

Only unloading the problematic mod is not straightforward without a user interface for enabling or disabling mods. People would get confused why their mod doesn't load.

As for mod dependencies I definitely want to add a dedicated id property which defaults to the mod folder name if not present in the metadata.

@EliteMasterEric EliteMasterEric added status: planned Planned to be implemented some time in the future. and removed status: pending triage Awaiting review. labels Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: planned Planned to be implemented some time in the future. topic: mods Related to the creation or use of mods. type: enhancement Involves an enhancement or new feature.
Projects
None yet
Development

No branches or pull requests

3 participants