Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thanks and a fix #11

Open
porcinus opened this issue Feb 11, 2023 · 4 comments
Open

Thanks and a fix #11

porcinus opened this issue Feb 11, 2023 · 4 comments

Comments

@porcinus
Copy link

First, a huge thanks for you library.
I never used a STC8 MCU before and your work greatly helped me :)

I made a "helper" file to compute and reverse compute some values related to prescalers.
If you are interested, you can borrow the file or any parts of it ;)
https://github.com/porcinus/NNS-Ambiclone-Mono/blob/main/code/src/FwLib_STC8_helper.h

During coding, I also notice an error (I think, haven't tried but this generate a error) in https://github.com/IOsetting/FwLib_STC8/blob/master/include/fw_rcc.h
In macro RCC_SetPowerDownWakeupTimerCountdown(16BIT_COUNT):
(16BIT_COUNT << 8) should be (16BIT_COUNT >> 8)

@IOsetting
Copy link
Owner

Thanks for the report, there are quite some errors in fw_rcc.h. I have updated it accordingly. Please let me know if there are any other errors.

@IOsetting
Copy link
Owner

FwLib_STC8_helper.h looks nice, I will borrow some code if you don't mind 😄

@porcinus
Copy link
Author

Thanks for the report, there are quite some errors in fw_rcc.h. I have updated it accordingly. Please let me know if there are any other errors.

This was the only error i noticed :)

@porcinus
Copy link
Author

FwLib_STC8_helper.h looks nice, I will borrow some code if you don't mind smile

Take any parts you want ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants