Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Structure Importer] Structures not importing in 4.12.2 #674

Closed
mchorse opened this issue Jan 23, 2025 · 2 comments
Closed

[Structure Importer] Structures not importing in 4.12.2 #674

mchorse opened this issue Jan 23, 2025 · 2 comments

Comments

@mchorse
Copy link
Contributor

mchorse commented Jan 23, 2025

I've tried Structure Importer plugin, and it doesn't work on newer version.

I tried it in 4.9.4, and it works there. My guess is that the issue stems from Electron version update. The root of the problem is that in older versions, whenever <input type="file"/> selects a file, it could have access to path property that points out to the full path of the file on the disk, and in newer versions, the path property is no longer available from FileList.

If I could get insight on how to fix this bug, I could patch it, and submit a PR, but I really don't want to rewrite the entire dialog to use proper functions to pick the path to NBT file... 😅

Thank you for attention!

@mchorse
Copy link
Contributor Author

mchorse commented Jan 23, 2025

Ah... it appears I accidentally created a duplicate for #605... should I close this ticket and move my notes there?

@JannisX11
Copy link
Owner

Yeah, if it's the same exact issue, which seems to be the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants