-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error: Could not find git root. #1
Comments
@mrustl The error comes out of |
@mrustl The error comes out of |
The error comes out of |
I also didn't create a github repo first. But the error doesn`t matter (for me) as it only leads to not creating the coverage badge.
I am dont sure whether this ERROR is already fixed in the latest Github version of usethis as there is now a little different code for this function in usethis (v.1.3.0.9000)
Source: https://github.com/r-lib/usethis/blob/b459a9f1875bfb8eeee2e9d2941dcb7203d6478e/R/ci.R In any case: the error caused being not a GIT repo in usethis (v.1.3.0) is not relevant for us as in kwb.pkgbuild the badge creation is performed during the README .(R)md build, which uses my own functions for creating the badges (see here). |
Furthermore the workflow demanded by the usethis package (first needs to be Git(hub) repository) does not really fit with what we usually do at KWB (e.g first develop internally, then publish on Github). In addition for following the usethis workflow the installation of GIT would be mandatory. Using the "bug" in kwb.pkgdown is much more inclusive because you can safely ignore the error! |
@hsonne the codecov badge creation ERROR does not occur in case you apply the following workflow:
|
@mrustl I know. I did it like that with kwb.readxl |
Running the following code leads to the error shown below:
Output:
The text was updated successfully, but these errors were encountered: