Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve reusability of kwb.pkgbuild #55

Open
mrustl opened this issue Mar 26, 2019 · 0 comments
Open

Improve reusability of kwb.pkgbuild #55

mrustl opened this issue Mar 26, 2019 · 0 comments
Assignees
Labels
enhancement New feature or request question Further information is requested
Milestone

Comments

@mrustl
Copy link
Member

mrustl commented Mar 26, 2019

@hsonne do you have an idea how the reusability of kwb.pkgbuild could be improved so it can be simple adapted for others. I am thinking about reusing it for https://github.com/DatenHelden

I have in mind to outsource the specific parts (e. g. use_installation()) into the template/config folder.

Ideally changes would need to be done only there without need to overwrite the function defaults as these would be based on the template/config.

At least I started with the template approach (also used by the usethis package) but I have no idea how to proceed with others now

@mrustl mrustl added enhancement New feature or request question Further information is requested labels Mar 26, 2019
@mrustl mrustl added this to the v0.2.0 milestone Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants