Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] When Make fails it still passes the GH Actions step and the test continues #51

Closed
itislu opened this issue Dec 29, 2023 · 1 comment · Fixed by #56
Closed

[CI] When Make fails it still passes the GH Actions step and the test continues #51

itislu opened this issue Dec 29, 2023 · 1 comment · Fixed by #56
Labels
bug Something isn't working devops Development related

Comments

@itislu
Copy link
Collaborator

itislu commented Dec 29, 2023 •
edited
Loading

The first automated test in PR #50 failed, but it should have failed earlier in step Compile with Makefile.
@itislu itislu added the devops Development related label Dec 29, 2023
@itislu itislu assigned LeaYeh and itislu and unassigned LeaYeh and itislu Dec 29, 2023
@LeaYeh LeaYeh added the bug Something isn't working label Dec 29, 2023
@itislu itislu changed the title [CI] When Make fails it still passes the job and the test continues [CI] When Make fails it still passes the GH Actions step and the test continues Dec 29, 2023
@itislu itislu linked a pull request Dec 30, 2023 that will close this issue
[CI] Add diff report to GH Actions #56
Merged
@itislu
Copy link
Collaborator Author

itislu commented Dec 30, 2023

Because of our custom messages for when Make encounters a build issue, the last command will actually be echo.
Therefore, make always exited with 0 because echo didn't fail.

I fixed it with calling exit with a custom exit code after the MSG_FAILURE gets printed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working devops Development related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[CI] Add diff report to GH Actions LeaYeh/minishell
2 participants
@LeaYeh @itislu