Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider making "persistent layering of methods" optional #42

Open
j4yk opened this issue Jun 29, 2016 · 1 comment
Open

Consider making "persistent layering of methods" optional #42

j4yk opened this issue Jun 29, 2016 · 1 comment

Comments

@j4yk
Copy link
Contributor

j4yk commented Jun 29, 2016

The feature implemented for #34 is useful in environments like Lively, but less so in ordinary web applications where methods are seldom or never modified. Since the additional getter call probably adds a performance overhead (which is yet to be measured...), it should be somehow configurable if that technique should be applied or not. In the latter case, the method wrapping should happen as it did before the changes to implement #34.

We could configure this behavior, for example, by adding a configure function or configuration object in the contextjs module.

@j4yk
Copy link
Contributor Author

j4yk commented Jul 19, 2016

Curiously, I can no longer measure the performance drop that we saw in the benchmark chart during the presentation. Although we got the same drop on both @LanDinh's and my machine before the presentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant