Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure out the rotation bug #4

Closed
Morozov-5F opened this issue Dec 29, 2020 · 2 comments · Fixed by #17
Closed

Figure out the rotation bug #4

Morozov-5F opened this issue Dec 29, 2020 · 2 comments · Fixed by #17
Assignees
@Morozov-5F
Labels
bug Something isn't working

Comments

@Morozov-5F
Copy link
Owner

For some reason if we rotate the cube for more than 45 degrees all kind of weird stuff happen -- some of the cube side becomes shaded, while others don't. Easiest way to reproduce the issue is change the "instance test" scene so the cube is rotated for more than 45 degrees.
@Morozov-5F Morozov-5F added the bug Something isn't working label Dec 29, 2020
@Morozov-5F Morozov-5F self-assigned this Dec 29, 2020
@Morozov-5F
Copy link
Owner Author

The issue also reproduces on polygonal models from #5. It feels like it has something to do with the normal vector pointing inside the surface.

@Morozov-5F
Copy link
Owner Author

This is probably due to a possible bug in the reference implementation: RayTracing/raytracing.github.io#965

Morozov-5F added a commit that referenced this issue Nov 28, 2021
@Morozov-5F
[#4] Fix the rotation bug due to incorrect front face setting.
fd3052e
@Morozov-5F Morozov-5F mentioned this issue Nov 28, 2021
Merged
Morozov-5F added a commit that referenced this issue Nov 28, 2021
@Morozov-5F
[#4] Fix error from previous commit when I passed ray reference by re…
203f0b5 
…ference.
Morozov-5F added a commit that referenced this issue Nov 28, 2021
@Morozov-5F
[#4] Fix issue when instance bounding box was calculated incorrectly.
cae29a6
Morozov-5F added a commit that referenced this issue Nov 28, 2021
@Morozov-5F
[#4] Adjust the instance scene.
b2969da
Morozov-5F added a commit that referenced this issue Nov 28, 2021
@Morozov-5F
[#4] Use proper transform for the cube in the metal showcase scene.
a2b5452
Morozov-5F added a commit that referenced this issue Nov 28, 2021
@Morozov-5F
Merge pull request #17 from Morozov-5F/bugfix/fix-rotation-bug
35012e4 
[#4] Fix the rotation bug due to incorrect front face setting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Morozov-5F Morozov-5F

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#4] Fix the rotation bug due to incorrect front face setting. Morozov-5F/raytracing-weekend
1 participant
@Morozov-5F