Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action breaks if logo_url has query at end #9

Closed
s-weigand opened this issue Mar 10, 2022 · 1 comment · Fixed by #10
Closed

Action breaks if logo_url has query at end #9

s-weigand opened this issue Mar 10, 2022 · 1 comment · Fixed by #10
Assignees
Labels
Bug Something isn't working Good first issue Good for newcomers

Comments

@s-weigand
Copy link

s-weigand commented Mar 10, 2022

Thanks for the awesome action 😍

When I ran it again today it broke due to a query at the end of the logo_url.
mv: cannot stat './git_repo/https://raw.githubusercontent.com/glotaran/pyglotaran/main/docs/source/images/glotaran.png?raw=true': No such file or directory

When I removed the query after reading

Displayed icon on bottom right corner. Can be local "./logo.png" or Url. For Url it must be png or jgp

- https://raw.githubusercontent.com/glotaran/pyglotaran/main/docs/source/images/glotaran.png?raw=true
+ https://raw.githubusercontent.com/glotaran/pyglotaran/main/docs/source/images/glotaran.png

It worked again

@NBprojekt NBprojekt added Good first issue Good for newcomers Bug Something isn't working labels Mar 11, 2022
@NBprojekt NBprojekt self-assigned this Mar 11, 2022
@NBprojekt
Copy link
Owner

NBprojekt commented Mar 11, 2022

Your image link works fine now. Fixed in v1.1.1

Check this run.

@NBprojekt NBprojekt pinned this issue Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants