Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement of oasis grid write routine #1353

Open
ukmo-juan-castillo opened this issue Jan 24, 2025 · 0 comments · May be fixed by #1354
Open

Improvement of oasis grid write routine #1353

ukmo-juan-castillo opened this issue Jan 24, 2025 · 0 comments · May be fixed by #1354
Labels
enhancement New feature or request

Comments

@ukmo-juan-castillo
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
There are no problems with this routine, but it could be written more efficient and consistently, generating grid files better compatible with the SCRIP format. 

Describe the solution you'd like
Writing the oasis grid for regular (non SMC) grids is done using three identical loops, which can be merged into one for better performance. The grid corners can also be calculated more efficiently, taking into account that the longitudes and latitudes of certain corner pairs will be the same. The computation gain is small though, but as the changes are simple it is worth doing it.

I also propose changing the value of the mask when writing SMC grids so that it follows the OASIS convention: 0 for sea points, 1 otherwise; and follow the SCRIP convention, where corners are written in counterclockwise order, starting with the one at the bottom left.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@ukmo-juan-castillo ukmo-juan-castillo added the enhancement New feature or request label Jan 24, 2025
@ukmo-juan-castillo ukmo-juan-castillo linked a pull request Jan 24, 2025 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant