You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
There are no problems with this routine, but it could be written more efficient and consistently, generating grid files better compatible with the SCRIP format.
Describe the solution you'd like
Writing the oasis grid for regular (non SMC) grids is done using three identical loops, which can be merged into one for better performance. The grid corners can also be calculated more efficiently, taking into account that the longitudes and latitudes of certain corner pairs will be the same. The computation gain is small though, but as the changes are simple it is worth doing it.
I also propose changing the value of the mask when writing SMC grids so that it follows the OASIS convention: 0 for sea points, 1 otherwise; and follow the SCRIP convention, where corners are written in counterclockwise order, starting with the one at the bottom left.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
There are no problems with this routine, but it could be written more efficient and consistently, generating grid files better compatible with the SCRIP format.
Describe the solution you'd like
Writing the oasis grid for regular (non SMC) grids is done using three identical loops, which can be merged into one for better performance. The grid corners can also be calculated more efficiently, taking into account that the longitudes and latitudes of certain corner pairs will be the same. The computation gain is small though, but as the changes are simple it is worth doing it.
I also propose changing the value of the mask when writing SMC grids so that it follows the OASIS convention: 0 for sea points, 1 otherwise; and follow the SCRIP convention, where corners are written in counterclockwise order, starting with the one at the bottom left.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: