Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Region Masking Functionality #42

Closed
4 tasks done
valentina-s opened this issue May 10, 2022 · 2 comments
Closed
4 tasks done

Region Masking Functionality #42

valentina-s opened this issue May 10, 2022 · 2 comments

Comments

@valentina-s
Copy link
Collaborator

valentina-s commented May 10, 2022

The mask function of the Regions2D object is not working currently.

The actual functionality is in the mask method of the Regions2DMasker

Working example for making "Hake" region masks (only one region) in this notebook.

Some considerations:

  • input could be one or many regions (based on region id's)
  • user wants all regions for a given label to be in the same mask
  • user want regions with different labels to be layers in the mask dataset
  • user wants regions with different labels to be in one layer (for example they want to combine all fish regions into one layer)
  • provide some options to the user how to store the pixel values of the masked regions

A few extra details:

  • adding regionmask version as a requirement
  • adding init.py
  • add examples in notebooks
  • add examples selecting different regions based on labels
@leewujung
Copy link
Member

#45 partially addressed this issue.

@leewujung leewujung added this to the Current status milestone May 22, 2023
@valentina-s
Copy link
Collaborator Author

The only one that is not addressed is 3) storing different regions in different layers. I will make a stand alone issue and we can discuss the format. #75

@ctuguinay ctuguinay removed the status in Echoregions May 28, 2023
@ctuguinay ctuguinay moved this to Done in Echoregions Jun 7, 2023
@ctuguinay ctuguinay mentioned this issue Jun 22, 2023
@ctuguinay ctuguinay linked a pull request Jun 26, 2023 that will close this issue
@ctuguinay ctuguinay removed a link to a pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants