Add Line Masking Functionality #83
Assignees
Milestone
Comments
Merged
Merged
ctuguinay
added a commit
that referenced
this issue
Jul 2, 2023
### Refactoring This PR closes the following issues: #91, #88, #83, #43. **The main folders are now:** - utils - lines - regions2d **As opposed to before:** - utils - convert - formats - mask - plot **Refactoring notes:** - `core.py` contains `read_evl` and `read_evr`. - In both regions2d and lines, plotting is still kept as a class function: `r2d.plot() `and `lines.plot()`. - In both regions2d and lines, masking is still kept as a class function: `r2d.mask() `and `lines.mask()`. - In both regions2d and lines, parsing is kept outside of class: `parse_regions_file(input_file)` and `parse_lines_file(input_file)`. - We now always initialize regions2d and lines with appropriate .evr and .evl functions at initialization ALWAYS. This is enforced with an error if not initialized properly (incorrect .evr or .evl file). **Other Changes Include:** - Added line masking based on Valentina's example notebook with options for what to do with NA values and what interpolation method to use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As of right now, there exists no such Line Mask in echoregion modules. We need line masking in order to get precise depth values to better Hake ML biomass calculations. To resolve this issue, a function line.mask(Sv, interp options) must be created that should include the following:
This implementation will repurpose the following code in the notebook created by Valentina Staneva as Hake Bottom Interpolation.
Sufficient implementation of this function will resolve this issue and those of #43, #82.
The text was updated successfully, but these errors were encountered: