Refactor Echoregions #91
Comments
Merged
Merged
ctuguinay
added a commit
that referenced
this issue
Jul 2, 2023
### Refactoring This PR closes the following issues: #91, #88, #83, #43. **The main folders are now:** - utils - lines - regions2d **As opposed to before:** - utils - convert - formats - mask - plot **Refactoring notes:** - `core.py` contains `read_evl` and `read_evr`. - In both regions2d and lines, plotting is still kept as a class function: `r2d.plot() `and `lines.plot()`. - In both regions2d and lines, masking is still kept as a class function: `r2d.mask() `and `lines.mask()`. - In both regions2d and lines, parsing is kept outside of class: `parse_regions_file(input_file)` and `parse_lines_file(input_file)`. - We now always initialize regions2d and lines with appropriate .evr and .evl functions at initialization ALWAYS. This is enforced with an error if not initialized properly (incorrect .evr or .evl file). **Other Changes Include:** - Added line masking based on Valentina's example notebook with options for what to do with NA values and what interpolation method to use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Due to the current organization of echoregions being somewhat convoluted and assuming too much about how many functionalities each of the subclasses for Lines and Echoregions2D share, we need to do some refactoring of the current structure.
The new structure will be as the following:
The tasks will be as follows:
regions2d/regions2d.pyregions2d/parser.pylines/lines.pylines/parser.pyutils/time_utils.py/echoregionsThe text was updated successfully, but these errors were encountered: