Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regions2d Replace Nan Depth Bug #98

Closed
1 task done
ctuguinay opened this issue Jun 26, 2023 · 0 comments · Fixed by #101
Closed
1 task done

Regions2d Replace Nan Depth Bug #98

ctuguinay opened this issue Jun 26, 2023 · 0 comments · Fixed by #101
Assignees
@ctuguinay
Labels
bug Something isn't working
Milestone
v0.1.0 (refactor ...

Comments

@ctuguinay
Copy link
Collaborator

ctuguinay commented Jun 26, 2023 •
edited
Loading

As @leewujung pointed out in #95 comments, the replace_nan_depth function in regions2d.py should return nothing when inplace=true as it should just be editing the values found in self.data; however, it is returning values and not editing values "in place".

  • Fix the case where inplace=True
@ctuguinay ctuguinay added the bug Something isn't working label Jun 26, 2023
@ctuguinay ctuguinay self-assigned this Jun 26, 2023
@ctuguinay ctuguinay moved this to Todo in Echoregions Jun 26, 2023
@ctuguinay ctuguinay mentioned this issue Jun 26, 2023
Merged
@ctuguinay ctuguinay moved this from Todo to Done in Echoregions Jun 26, 2023
@ctuguinay ctuguinay mentioned this issue Jun 26, 2023
Closed
@ctuguinay ctuguinay linked a pull request Jun 26, 2023 that will close this issue
Fix replace nan depth bug #101
Merged
@ctuguinay ctuguinay moved this from Done to Review Needed in Echoregions Jun 30, 2023
@ctuguinay ctuguinay mentioned this issue Jul 2, 2023
Merged
@github-project-automation github-project-automation bot moved this from Review Needed to Done in Echoregions Jul 3, 2023
@ctuguinay ctuguinay linked a pull request Jul 7, 2023 that will close this issue
Improve Testing #115
Merged
@ctuguinay ctuguinay removed a link to a pull request Jul 7, 2023
Improve Testing #115
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ctuguinay ctuguinay

Labels
bug Something isn't working
Projects
Echoregions
Status: Done
Milestone
v0.1.0 (refactor echoregions)
Development

Successfully merging a pull request may close this issue.

Fix replace nan depth bug ctuguinay/echoregions
1 participant
@ctuguinay