-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow opentrader up to specify a custom port #92
Comments
#92 Adding --port flag for daemon start optionsDescriptionCurrently, Tasks
new Option("-p, --port <port>", "Customize port server should attach to").default(8000)
@bludnic, let me know if I missed anything! I quickly wrote out the tasks for this PR while the daemon package is still fresh in my mind. |
@montymi Thanks! You described it perfectly. |
Sweet! Taking a look at this now and I'll push my changes later tonight. |
Assign me With this task if it's not completed yet ? @akanoce |
@Charlesnorris509 yes feel free to take it, I hadn't time to look into this yet. I think @bludnic can assign you the task |
Hey @Charlesnorris509, you can check other tasks with
good first issue
|
Just pushed my changes in #95 |
Merged #95. Will be included in the next release. |
Currently, the
opentrader up
command defaults to using port8000
, with no option to override it. This can cause conflicts if port 8000 is already in use by another service, forcing users to manually stop those services or look for workarounds.It would be helpful to add an optional
--port
(or-p
) parameter to theopentrader up
command. This would allow users to specify a custom port, making the tool more flexible in environments with conflicting services.The text was updated successfully, but these errors were encountered: