Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neighborhood names sometimes contain commas, which messes up CSV API outputs #3756

Open
jsomeara opened this issue Nov 29, 2024 · 2 comments · May be fixed by #3770
Open

Neighborhood names sometimes contain commas, which messes up CSV API outputs #3756

jsomeara opened this issue Nov 29, 2024 · 2 comments · May be fixed by #3770
Assignees

Comments

@jsomeara
Copy link
Collaborator

Brief description of problem/feature

Some neighborhood names in Chicago contain commas:
image
image

When we request /v2/rawLabels, the commas get included in the CSV without being properly put in quotes, leading to issues with parsing the CSV:

image

Expected behavior

The commas should be dealt with by putting the neighborhood name in quotes so that csv readers can properly parse the content.

Steps to reproduce
  1. Fetch chicago /v2/rawLabels csv file
Potential solution(s)

Add quotes around neighborhood name in the returned CSV

@misaugstad
Copy link
Member

Whoops! Looks like we fixed this for most APIs in #3392 but this one was missed! Nice catch @jsomeara!

@misaugstad
Copy link
Member

@ananyaa06 if you don't have a neighborhood in your local db with a comma in it, you can just edit the name of a neighborhood in your db to add a comma for testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants