Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal error in latest release 1.3.0 #12

Open
lruozzi9 opened this issue Feb 1, 2023 · 1 comment
Open

Fatal error in latest release 1.3.0 #12

lruozzi9 opened this issue Feb 1, 2023 · 1 comment

Comments

@lruozzi9
Copy link

lruozzi9 commented Feb 1, 2023

Hi @loevgaard! There is an error in the latest release of this plugin. We checked it thanks to PHPStan during the CI tests run by dependabot while trying to upgrade the plugin. The error is the following:

Child process error (exit code 255): PHP Fatal error:  Type of Setono\TagBag\Tag\TwigTag::$name must be string (as in class Setono\TagBag\Tag\TemplateTag) in /.../vendor/setono/tag-bag-twig/src/Tag/TwigTag.php on line 7 

Fatal error: Type of Setono\TagBag\Tag\TwigTag::$name must be string (as in class Setono\TagBag\Tag\TemplateTag) in /.../vendor/setono/tag-bag-twig/src/Tag/TwigTag.php on line 7
lruozzi9 added a commit to lruozzi9/tag-bag-twig that referenced this issue Feb 1, 2023
Update TwigTag to make it compatible again with TemplateTag. See Setono/SyliusTagBagPlugin#12.
@lruozzi9
Copy link
Author

lruozzi9 commented Feb 1, 2023

The error is given by the simultaneous use of setono/tag-bag v1.5.0 and setono/tag-bag-twig v1.1.1. Probably, a new major of the setono/tag-bag-twig should be released after merging this, and incompatibility should be put in this plugin with <v2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant