Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to fabric-api mod ID for clarity #183

Open
Poopooracoocoo opened this issue Dec 21, 2024 · 4 comments
Open

Switch to fabric-api mod ID for clarity #183

Poopooracoocoo opened this issue Dec 21, 2024 · 4 comments
Assignees
Labels
1.18 Affects 1.18 1.19 Affects 1.19 1.20 Affects 1.20 1.21 Affects 1.21

Comments

@Poopooracoocoo
Copy link

Poopooracoocoo commented Dec 21, 2024

You're using the outdated fabric ID for Fabric API. Fabric API still "provides" the fabric mod ID for compatibility, but it's not clear what it is, so you should use the fabric-api mod ID.

Ref. https://github.com/StellarWind22/Fabric-Shield-Lib/blob/main/src/main/resources/fabric.mod.json#L60

@CringeStar
Copy link
Collaborator

Didnt know about this change, will do though! Is this just for 1.21.x versions or do previous versions also need this change?

@Poopooracoocoo
Copy link
Author

The fabric-api mod ID is in FAPI versions for 1.18.2 and above.

@CringeStar CringeStar added 1.18 Affects 1.18 1.19 Affects 1.19 1.20 Affects 1.20 1.21 Affects 1.21 labels Dec 21, 2024
@CringeStar
Copy link
Collaborator

Got it

@CringeStar CringeStar added this to the 1.8 milestone Dec 21, 2024
@CringeStar CringeStar self-assigned this Dec 21, 2024
@CringeStar
Copy link
Collaborator

Done in 1.21.3 and 1.21.4 so far

@CringeStar CringeStar modified the milestones: 1.8, Minor Important Tweaks Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.18 Affects 1.18 1.19 Affects 1.19 1.20 Affects 1.20 1.21 Affects 1.21
Projects
None yet
Development

No branches or pull requests

2 participants