Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style and Contributing questions #2

Open
sbehrens opened this issue Oct 18, 2017 · 0 comments
Open

Style and Contributing questions #2

sbehrens opened this issue Oct 18, 2017 · 0 comments

Comments

@sbehrens
Copy link

I'm currently investigating the post-breach/simulation space and was considering building my own framework for this. Dumpster Fire looks like it would solve some of my use cases, specifically the modules you have provided.

Menu driven support wont work for our end goal, which is more autonomous game days launched via our CI pipelines. We'd like to end up in a place where we'd run simulations at random with various configurations, driven by config files/json and not user controlled input.

I'm considering writing that portion based on Dumpster Fire but I had some questions around the style before beginning. It seems that Dumpster Fire uses a combination of Java and Python style. Some of the fire modules have class names in lower case and method names in Java case which is the opposite of Pep8. some method definitions call self like this:

def foo( self ):

or

def Foo(self):

Would you have any problems if I started normalizing/linting the code as I'm contributing to be in line with Pep8 style format? In addition, would a config/json test initialization support be useful for contributing?

-Scott

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant