You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add a note in the access-decision-manger repo for developers.
Since this repo is going to be mainly used for developers with the intention of binding this functionality to different tools like express, react, vue ... etc.
A note saying something like the next text is helpful
“This package is primarily intended to be used by one of the following (list of express / react / vue bindings)”
After a review from Bergfeld about
how easy it would be as "new eyes" to use it
we got some great feedback from him and here are some things that can be improved
-
supports
andvoteOnAttribute
Explain
supports
andvoteOnAttribute
in a detailed way, what is their specific function, and why both existMatt's explanation:
- Remove unused/confusing code
Remove the unused import { Voter } in the readme example
Voter
is a typescript type.https://github.com/wizeline/access-decision-manager/blame/master/packages/access-decision-manager/README.md#L42
- Add note for developers
Add a note in the access-decision-manger repo for developers.
Since this repo is going to be mainly used for developers with the intention of binding this functionality to different tools like express, react, vue ... etc.
A note saying something like the next text is helpful
“This package is primarily intended to be used by one of the following (list of express / react / vue bindings)”
- Authorization strategies
Add info about the authorization strategies
#23
The text was updated successfully, but these errors were encountered: