ZCiCalNode::addNode() incorrectly handles multiple nodes with same name

[pbiron]

Consider the following code:

$ical = new ZCiCal();
$vevent = new ZCiCalNode( 'VEVENT', $ical->curnode );
$vevent->addNode( new ZCiCalDataNode( 'RDATE:20180310' ) );
$vevent->addNode( new ZCiCalDataNode( 'RDATE:20180324' ) );
$ical-export();

The above results in output like:

BEGIN:VCALENDAR
PRODID:-//ZContent.net//ZapCalLib 1.0//EN
VERSION:2.0
BEGIN:VEVENT
RDATE:20180324
RDATE:20180324
END:VEVENT
END:VCALENDAR

which is incorrect: notice that both RDATE nodes in the output contain the value of last RDATE node added.

The correct output should be:

BEGIN:VCALENDAR
PRODID:-//ZContent.net//ZapCalLib 1.0//EN
VERSION:2.0
BEGIN:VEVENT
RDATE:20180310
RDATE:20180324
END:VEVENT
END:VCALENDAR

I've got a fix to ZCiCalNode::addNode() that results in the correct output for this particular case. I can submit a PR. However, since I'm really new to writing code to generate iCalendar feeds I'm not sure whether my fix will break other cases, and since you don't have any unit tests it's hard for me to tell.

Should I submit the PR anyway?

[cogliano]

Hi Paul, Thanks for the report. I can confirm the issue with the example you provided. I need to fix it but if you already have a fix go ahead and submit it. Thanks.

…

On 2018-03-13 12:50 pm, Paul Biron wrote: Consider the following code: $ical = new ZCiCal(); $vevent = new ZCiCalNode( 'VEVENT', $ical->curnode ); $vevent->addNode( new ZCiCalDataNode( 'RDATE:20180310' ) ); $vevent->addNode( new ZCiCalDataNode( 'RDATE:20180324' ) ); $ical-export(); The above results in output like: BEGIN:VCALENDAR PRODID:-//ZContent.net//ZapCalLib 1.0//EN VERSION:2.0 BEGIN:VEVENT RDATE:20180324 RDATE:20180324 END:VEVENT END:VCALENDAR which is incorrect: notice that BOTH RDATE nodes in the output contain the value of LAST RDATE node added. The correct output should be: BEGIN:VCALENDAR PRODID:-//ZContent.net//ZapCalLib 1.0//EN VERSION:2.0 BEGIN:VEVENT RDATE:20180310 RDATE:20180324 END:VEVENT END:VCALENDAR I've got a fix to ZCiCalNode::addNode() that results in the correct output for this particular case. I can submit a PR. However, since I'm really new to writing code to generate iCalendar feeds I'm not sure whether my fix will break other cases, and since you don't have any unit tests it's hard for me to tell. Should I submit the PR anyway? -- You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub [1], or mute the thread [2].

-- -- Dan Cogliano ZContent.net Links: ------ [1] #5 [2] https://github.com/notifications/unsubscribe-auth/AKgNkvtEbgpkpKRNy_3C36doRHFxiOQOks5td_jvgaJpZM4SpEGI