Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Superseding alerts does not work #1

Open
zachomedia opened this issue May 29, 2018 · 1 comment
Open

Superseding alerts does not work #1

zachomedia opened this issue May 29, 2018 · 1 comment
Labels
alerts service bug Something isn't working

Comments

@zachomedia
Copy link
Member

zachomedia commented May 29, 2018

Need to handle: If the alerts get processed out of order, superseding of alerts does not take place (i.e., the flag superseded is still false).

When processing a new alert, the alert service should check for alerts referencing the current alert. If yes, then supersede it.

An alternative is to have a cleanup cron job run every so often.

@zachomedia zachomedia added bug Something isn't working alerts service labels May 29, 2018
@zachomedia zachomedia changed the title Superseding alerts does not work if the alert is not preset Superseding alerts does not work if the alert is not present May 29, 2018
@zachomedia zachomedia changed the title Superseding alerts does not work if the alert is not present Superseding alerts does not work May 29, 2018
@zachomedia
Copy link
Member Author

Implemented.

There is a race condition though, so rarely alerts are not superseded as they should be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alerts service bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant