Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move class-star to a separate repository #1102

Closed
Ambrevar opened this issue Jan 20, 2021 · 5 comments · Fixed by #2784
Closed

Move class-star to a separate repository #1102

Ambrevar opened this issue Jan 20, 2021 · 5 comments · Fixed by #2784
Labels

Comments

@Ambrevar
Copy link
Member

I've asked defclass* upstream if they are still maintaing their package and would accept to merge the class* changes.

If not, then I suggest we publish this library, it's too useful to be left inside Nyxt :)
@jmercouris: Shall I move it to @atlas-engineer or to @Ambrevar?

@jmercouris
Copy link
Member

I would suggest all libraries we build in the context of Nyxt go to the atlas engineer repository, so that our community contributions are evident

@Ambrevar
Copy link
Member Author

Ambrevar commented Feb 2, 2021

Good news, upstream has accepted most of my patches.
Only one remains dangling: hu-dwim/hu.dwim.defclass-star#3

If it gets merged, then we can switch to the latest version of hu.dwim.deefclass-star.

@Ambrevar
Copy link
Member Author

For now Quicklisp only publishes the stable tag of https://github.com/hu-dwim/hu.dwim.defclass-star, so we need to wait until this gets updated before we can get rid of our class-star library.

@Ambrevar
Copy link
Member Author

Maybe Quicklisp won't update the package anytime soon, so instead I suggest using a submodule for defclass-star.

Then we can remove libraries/class-star and define our own define-class in Nyxt that automatically sets the user class when the class name is exported.

@Ambrevar Ambrevar added the high label May 19, 2021
@Ambrevar
Copy link
Member Author

When we do, rename defcondition* to define-condition*.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

2 participants