Tiled animation duration on the wrong frame?

[rudiHammad]

Hello,
the video bellow shows how I set a 1000 ms on the water frame, an 100 ms on the others. In Tiled it shows as expected,
but in axmol it seems that 1000 ms is not applied where it should.
I did a search with "Tiled" "animation" "duration" and didn't find any topic about. Is that a bug?

2025-01-21.11-09-07.mp4

[rh101]

the video bellow shows how I set a 1000 ms on the water frame, an 100 ms on the others. In Tiled it shows as expected,
but in axmol it seems that 1000 ms is not applied where it should.
I did a search with "Tiled" "animation" "duration" and didn't find any topic about. Is that a bug?

If you face any kind of issue, then always supply a sample project, or at the very least, sample resource files (the tilemap/graphics) as well as a code snippet showing how they are used.

The reason is that if these things are not provided, then anyone wanting to investigate the issue would first have to figure out how to set it all up; creating the resources, code etc., and that's not even guaranteed to reproduce it. All of this is time wasted, and it's not even related to looking at the actual issue. This is perhaps the reason why developers would take their time replying to posts, or even avoid them altogether (this is with all open source projects, not just Axmol).

Just to clarify, I'm not having a go at you about this, but rather pointing out that if you want real help, then that's the best way to get it.

[rudiHammad]

@rh101 fair enough. I just though that it was maybe a quick thing to detect.
Here's the project and the explanation in the ReadMe.md

https://github.com/rudiHammad/tilemap-axmol-test/blob/timeFrameBug/README.md

cheers

[rh101]

What exactly would we need to look for in Tiled to see the animation?

The tmx and tsx files do not contain any kind of timing, so are they the correct resources to reproduce the issue?

EDIT: I just noticed that it's not the main branch, but "timeFrameBug".

[rudiHammad]

if you open the tsx in TIled, you can see in the image above that first you select that tile, and then click on the camera.
This opens the timing of each frame.

myTileset.tsx is

<?xml version="1.0" encoding="UTF-8"?>
<tileset version="1.10" tiledversion="1.11.0" name="myTileset" tilewidth="24" tileheight="24" tilecount="8" columns="4">
 <image source="myTileset.png" width="96" height="48"/>
 <tile id="5">
  <animation>
   <frame tileid="0" duration="100"/>
   <frame tileid="1" duration="100"/>
   <frame tileid="2" duration="1000"/>
   <frame tileid="3" duration="100"/>
  </animation>
 </tile>
</tileset>

[rh101]

Yep, thanks, I can see it now. On cloning the git repo it automatically sets the "main" branch, not "timeFrameBug", so it was the incorrect source that I copied across.

[rudiHammad]

Cool. I was a bit lazy and did a branch to get it out instead of a new repo.

[rh101]

OK, so the logic isn't correct in TMXTileAnimTask. There is a quick fix, but I think that it would be preferrable to fix the logic properly.

If you want a quick fix, change this:

void TMXTileAnimTask::tickAndScheduleNext(float dt)
{
    setCurrFrame();
    _layer->getParent()->scheduleOnce(AX_CALLBACK_1(TMXTileAnimTask::tickAndScheduleNext, this),
                                      _animation->_frames[_currentFrame]._duration / 1000.0f, _key);
}

to this:

void TMXTileAnimTask::tickAndScheduleNext(float dt)
{
    setCurrFrame();
    _layer->getParent()->scheduleOnce(AX_CALLBACK_1(TMXTileAnimTask::tickAndScheduleNext, this),
                                      _animation->_frames[(_currentFrame - 1) % _frameCount]._duration / 1000.0f, _key);
}

[rh101]

Fixed in #2345

[rudiHammad]

Awesome thanks.
For now I'll do the quick fix. I'll update axmol when future versions include that fix.

[rh101]

The logic fix was much simpler than I thought it would be, so you can copy the code from the PR too if you prefer. Both fixes would work the same way, it's just the one in the PR makes a lot more sense for anyone reading the code.

[rudiHammad]

Nice, done.