Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home page doesn't load (new elements lead to exception) #270

Closed
sifferhans opened this issue Jan 17, 2024 · 3 comments
Closed

Home page doesn't load (new elements lead to exception) #270

sifferhans opened this issue Jan 17, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@sifferhans
Copy link
Collaborator

The home page doesn't load.
CleanShot 2024-01-17 at 12 23 36@2x

@sifferhans sifferhans added the bug Something isn't working label Jan 17, 2024
@SimonSimCity
Copy link
Collaborator

SimonSimCity commented Jan 24, 2024

Seems to be fixed without giving it any attention ... Maybe the PR #269 did something, but otherwise I don't know ... @kkuepper do you know about anything that was changed to get this working again?

@kkuepper
Copy link
Member

kkuepper commented Jan 24, 2024

I didn't notice there was an issue about it.

I disabled the project-box for the website.
(Detailed explanation: I added a MinVersion to the project-box element. Since the Website doesn't send an app version, the website doesn't get the project-box in the discover request anymore.)

That does highlight 2 problems though:

  1. If a new unknown element is added, the website should just ignore it and not throw an error that prevents the whole list from being shown.
  2. I don't know how to update bmm-fetch so that the website knows about the new element. Actually it's only @SimonSimCity that knows how to do that. The best would be to have a github action that creates a new package version automatically.

We must fix at least 1 of those problems.

@kkuepper kkuepper changed the title Home page doesn't load Home page doesn't load (new elements lead to exception) Jan 24, 2024
@SimonSimCity
Copy link
Collaborator

SimonSimCity commented Jan 26, 2024

IMO, solving 2) would just shorten the time of an error like this to be fixed, whereby 1) would prevent it in the first run from happening. This said, 1) should have the focus here.

Issue 1) should be fixed by #33, and 2) there's not anything more to it than running the 3 commands described in the readme of the package (https://github.com/bcc-code/bmm-sdk).

But this always also depends on how strong the structure of the backend is changed. If there's something which has been replaced, this might eventually pose some issues - same as if data is not according to the specs - the swagger file.

At least the rest of the website remained usable 🤪 Might be good to show something else than a blank page in case of an exception, but that's again part of #33.

Closing this issue as resolved. That an issue like this should not come up again has to be set in #33.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants