From 0c86cdfdbd2615b4058a43b1265a9f4f58cddbc7 Mon Sep 17 00:00:00 2001 From: felix-hoc Date: Wed, 8 Jan 2025 13:11:47 +0100 Subject: [PATCH 1/4] Fix unexpected reset of CEA caption setup when enabling captions --- src/ts/components/subtitleoverlay.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ts/components/subtitleoverlay.ts b/src/ts/components/subtitleoverlay.ts index 2b78ea6ad..9a7e3d122 100644 --- a/src/ts/components/subtitleoverlay.ts +++ b/src/ts/components/subtitleoverlay.ts @@ -347,7 +347,7 @@ export class SubtitleOverlay extends Container { }); player.on(player.exports.PlayerEvent.SourceUnloaded, reset); - player.on(player.exports.PlayerEvent.SubtitleEnabled, reset); + player.on(player.exports.PlayerEvent.SubtitleEnable, reset); player.on(player.exports.PlayerEvent.SubtitleDisabled, reset); } From c7b904620d7d5fb83c0ab19596ecee89a7067249 Mon Sep 17 00:00:00 2001 From: felix-hoc Date: Wed, 8 Jan 2025 13:12:26 +0100 Subject: [PATCH 2/4] Add changelog entry --- CHANGELOG.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index f4a768362..58fb51cc5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,11 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](http://keepachangelog.com/) and this project adheres to [Semantic Versioning](http://semver.org/). +## [Unreleased] + +### Fixed +- Unexpected styling for the initially displayed cue when enabling CEA-608 captions + ## [3.79.0] - 2025-01-08 ### Fixed From a79e4486a67762cad980fd86bfb368542a004b29 Mon Sep 17 00:00:00 2001 From: felix-hoc Date: Wed, 8 Jan 2025 14:23:45 +0100 Subject: [PATCH 3/4] Fix caption alignment on small player sizes --- src/scss/skin-modern/components/_subtitleoverlay-cea608.scss | 1 + 1 file changed, 1 insertion(+) diff --git a/src/scss/skin-modern/components/_subtitleoverlay-cea608.scss b/src/scss/skin-modern/components/_subtitleoverlay-cea608.scss index 3c072fd81..5911bd7ba 100644 --- a/src/scss/skin-modern/components/_subtitleoverlay-cea608.scss +++ b/src/scss/skin-modern/components/_subtitleoverlay-cea608.scss @@ -27,6 +27,7 @@ display: inline-block; font-family: 'Courier New', Courier, 'Nimbus Mono L', 'Cutive Mono', monospace; text-transform: uppercase; + vertical-align: bottom; // sass-lint:disable force-pseudo-nesting nesting-depth &:nth-child(1n-1)::after { From cd80bafbfd959b7499f342036109eab679af3312 Mon Sep 17 00:00:00 2001 From: felix-hoc Date: Wed, 8 Jan 2025 14:25:36 +0100 Subject: [PATCH 4/4] Extend changelog entry --- CHANGELOG.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 58fb51cc5..1b579d862 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,7 +7,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/). ## [Unreleased] ### Fixed -- Unexpected styling for the initially displayed cue when enabling CEA-608 captions +- Unexpected styling for the initially displayed cue when enabling CEA-608 captions +- Vertical alignment of CEA-608 captions on small player sizes ## [3.79.0] - 2025-01-08