Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon fails to load in latest alphas and will break in 2022.1 #16

Open
fastfinge opened this issue Dec 23, 2021 · 5 comments
Open

Addon fails to load in latest alphas and will break in 2022.1 #16

fastfinge opened this issue Dec 23, 2021 · 5 comments

Comments

@fastfinge
Copy link

Running latest code from source. This has to do with this change:
• controlTypes has been split up into various submodules, symbols marked for deprecation must be replaced before 2022.1. (#12510)
◦ ROLE_* and STATE_* constants should be replaced to their equivalent Role.* and State..
◦ roleLabels, stateLabels and negativeStateLabels have been deprecated, usages such as roleLabels[ROLE_
] should be replaced to their equivalent Role..displayString or State..negativeDisplayString.
◦ processPositiveStates and processNegativeStates have been deprecated for removal.

I spent a couple hours trying to figure out how to keep things going without a major refactor, but didn't get anywhere.

@mush42
Copy link
Collaborator

mush42 commented Dec 23, 2021

Noted and will be fixed.

Regards,

1 similar comment
@mush42
Copy link
Collaborator

mush42 commented Dec 23, 2021

Noted and will be fixed.

Regards,

@dnz3d4c
Copy link

dnz3d4c commented May 25, 2023

@mush42 Modifications are required to work with NVDA 2023.1.
Thanks.

@ElCrackLoko
Copy link

@mush42 Please don't abandon this plugin, many people use it. IF you need an incentive or something, please say so or add it in your plugin. Don't let him die. If I knew how to program, I would help with code improvements or things like that, but I'm not a programmer, just a web designer

@ElCrackLoko
Copy link

ElCrackLoko commented May 25, 2023

@dnz3d4c I'm against changing the manifest, but it's still compatible with NVDA 2023.1.0 if you change it, if you don't know how to do it, let me know and I'll give you instructions. I say it's not ideal because the code should be reviewed, but it's the last thing we have left. Someone passed me this modified version a year ago or maybe more, when the update to NVDA 2022.1.0 was released, this version I share with you. This same, if the Manifesto is modified in version 2023, it continues to work
audiothemes.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants