-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lasercutoutBox: have num_fingers be an array (vs. a scalar value) #13
Comments
I like the idea. I will add to a to do file. Any PR as a starter ? |
@phdoerfler if you're still interested in this, I've added a finger_width to my fork AlexCPU#4. I haven't submitted a PR to this, as I've made breaking changes to get symmetrical fingers. |
@AlexCPU interesting, thanks for the pointer! |
Wow, I was just about to open an issue when I saw @AlexCPU has already done it! I like using this lasercut tool a lot in my OpenSCAD projects, I recently made them available here. What I'm missing are two features:
Alternatively, we can borrow Alex's approach to pass the Simple tab finger joints larger than the material thickness will sustain more weight put on them (see the inner stut in my router case example). In either case, I'd like to see Alex's PR merged! That's really a great job. |
An option to implement this could be to check for the type of the parameter, converting to always be an array in the function, so you could adjust the number based on the sizes:
Still not as nice as specifying the width though. |
Boxes like this (
num_fingers = 2
) would look nicer if the finger width would be more consistent between short and long sides:Either implement some
finger_width
parameter or turnnum_fingers
into an array so it's possible to specify the number of fingers per side.The text was updated successfully, but these errors were encountered: