Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generation logic of deps.js is outdated. #160

Open
KOH922 opened this issue Nov 7, 2018 · 0 comments
Open

Generation logic of deps.js is outdated. #160

KOH922 opened this issue Nov 7, 2018 · 0 comments

Comments

@KOH922
Copy link

KOH922 commented Nov 7, 2018

The current plovr RAW mode does not support the module_flag parameter of goog.addDependency().

for (JsInput input : inputs) {
builder.append("goog.addDependency(" +
toJsString.apply(converter.apply(input)) +
", [" +
comma.join(Lists.transform(input.getProvides(), toJsString)) +
"], [" +
comma.join(Lists.transform(input.getRequires(), toJsString)) +
"]);\n");
}

Closure-Library now takes module_flag as the 4th argument and can now specify module,lang.

If module does not contain goog, it will not correctly parse goog.module(...) and an error will result. https://github.com/google/closure-library/wiki/ES6-modules-and-Closure-Library#the-debug-loader-and-es6-modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant