Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split path to path and cached_path. #8

Open
fridek opened this issue Aug 22, 2013 · 0 comments
Open

Split path to path and cached_path. #8

fridek opened this issue Aug 22, 2013 · 0 comments

Comments

@fridek
Copy link

fridek commented Aug 22, 2013

Background:
I work on a project with 150k LOC. It uses Closure and four other libraries, all compiled using plovr. SIMPLE mode output is over 6MB.
When this code used to live in remote filesystem each reload would take 30-40s to recompile in SIMPLE mode. ADVANCED was even worse. We disabled all checks to make it that fast (slow) too.
With code stored locally reload takes 10-15s which is closer to acceptable, but I think it could be much better if plovr would parse some of the files only once on run and then watch only those specified as not cached. In common user scenario it would allow fast linking with libraries, like I often link to latest Closure in my personal projects. In our case it would allow us to create configs for each component dev is working on with all others cached.

I think it may have some dependencies on closure compiler (can you inject the same AST into different compilation runs?). If they are not resolvable, all files marked as cached could be concated into one temporary file and processed on each run in such form.

Regarding goog.require between uncached and cached files - I think it's safe to assume that dev can reload plovr server whenever deps change. It can be also actually implemented that whenever deps change, all cache has to be purged.

nicks pushed a commit that referenced this issue Jun 3, 2015
Support for IfNodes as traditional conditionals and ternary expressions where possible.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=86653446
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant