Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile localizations #88

Open
robfig opened this issue Jan 22, 2016 · 5 comments
Open

Compile localizations #88

robfig opened this issue Jan 22, 2016 · 5 comments

Comments

@robfig
Copy link

robfig commented Jan 22, 2016

Hi @nicks ,
Is it possible to generate one artifact per locale, provided a list of locales? The near-term question is about using the date and number formatting functions pruned just to the locale that the bundle is for (otherwise the locale info maps are too big and we can't use goog.i18n). We have our translations in .po files so I guess there is no support for hooking that up to goog.getMsg, but we have our own system for that right now.
Thanks,
Rob

@nicks
Copy link
Collaborator

nicks commented Jan 22, 2016

I don't think there's a built-in way to do this now but I think it'd be
straightforward to add a locales option? Alternatively, you could probably
hack it by having N plovr configs, one per language.
On Jan 22, 2016 6:29 PM, "Rob Figueiredo" notifications@github.com wrote:

Hi @nicks https://github.com/nicks ,
Is it possible to generate one artifact per locale, provided a list of
locales? The near-term question is about using the date and number
formatting functions pruned just to the locale that the bundle is for
(otherwise the locale info maps are too big and we can't use goog.i18n). We
have our translations in .po files so I guess there is no support for
hooking that up to goog.getMsg, but we have our own system for that right
now.
Thanks,
Rob


Reply to this email directly or view it on GitHub
#88.

@imirkin
Copy link
Collaborator

imirkin commented Jan 22, 2016

I've probably mentioned this before, but I have, by now, an ancient patchset which enables locale support in plovr:

https://codereview.appspot.com/6194048/
https://codereview.appspot.com/6201051/

I believe my approach in those patches was to do them one language at a time.

@atannus
Copy link
Contributor

atannus commented Mar 13, 2016

I believe these patches no longer apply to the code base. Do you still
maintain them Ilia?

On Fri, Jan 22, 2016 at 7:19 PM, Ilia Mirkin notifications@github.com
wrote:

I've probably mentioned this before, but I have, by now, an ancient
patchset which enables locale support in plovr:

https://codereview.appspot.com/6194048/
https://codereview.appspot.com/6201051/

I believe my approach in those patches was to do them one language at a
time.


Reply to this email directly or view it on GitHub
#88 (comment).

André Tannús | Epungo | +55 11 2389-4360
We are a layer

@atannus
Copy link
Contributor

atannus commented Mar 15, 2016

I took some time to port Ilia's patch to the latest plovr build.

https://github.com/atannus/plovr/tree/translation-support

How should I proceed to integrate these changes?
Just open a pull request?
AT

On Sun, Mar 13, 2016 at 6:44 PM, Andre Tannus andre.tannus@gmail.com
wrote:

I believe these patches no longer apply to the code base. Do you still
maintain them Ilia?

On Fri, Jan 22, 2016 at 7:19 PM, Ilia Mirkin notifications@github.com
wrote:

I've probably mentioned this before, but I have, by now, an ancient
patchset which enables locale support in plovr:

https://codereview.appspot.com/6194048/
https://codereview.appspot.com/6201051/

I believe my approach in those patches was to do them one language at a
time.


Reply to this email directly or view it on GitHub
#88 (comment).

André Tannús | Epungo | +55 11 2389-4360
We are a layer

André Tannús | Epungo | +55 11 2389-4360
We are a layer

@nicks
Copy link
Collaborator

nicks commented Mar 15, 2016

yep, pull-request will work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants