Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint fails due to old tox version #1183

Closed
orfeas-k opened this issue Dec 9, 2024 · 3 comments
Closed

lint fails due to old tox version #1183

orfeas-k opened this issue Dec 9, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@orfeas-k
Copy link
Contributor

orfeas-k commented Dec 9, 2024

Bug Description

Linting fails in the following repos due to installed an old tox version. This should be fixed in all CKF repos and tackled probably in #1182 and #1057.

  • argo-operators
  • knative-operators
  • kubeflow-profiles-operator
  • metacontroller-operator
  • namespace-node-affinity-operator

To Reproduce

See update requirements PRs e.g. canonical/namespace-node-affinity-operator#60 and https://github.com/canonical/namespace-node-affinity-operator/actions/runs/12232032232/job/34116268061?pr=60#step:4:10. The files are fixed and pass using latest tox version available.

Environment

CI

Relevant Log Output

n/a

Additional Context

No response

@orfeas-k orfeas-k added the bug Something isn't working label Dec 9, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-6653.

This message was autogenerated

@orfeas-k
Copy link
Contributor Author

orfeas-k commented Dec 9, 2024

When bumping tox in argo-operators, we hit the issue where tox -vve argo-controller-lint failed with error:

lint: 2171127 C exit 247 (2170.63 seconds) /home/runner/work/argo-operators/argo-operators> tox -vve lint -c /home/runner/work/argo-operators/argo-operators/charms/ pid=1930 [tox/execute/api.py:286]
  lint: FAIL code 247 (2171.08=setup[0.45]+cmd[2170.63] seconds)
  evaluation failed :( (2171.33 seconds)

where we can see that for some reason the tox command is called from tox -vve lint -c /home/runner/work/argo-operators/argo-operators/charms/ and not .../charms/argo-controller. In order to avoid that, we modified the order of the tox command

-    tox -vve {env:TYPE} -c {toxinidir}/charms/{env:CHARM}
+    tox  -c {toxinidir}/charms/{env:CHARM} -vve {env:TYPE}

orfeas-k added a commit to canonical/argo-operators that referenced this issue Dec 10, 2024
orfeas-k added a commit to canonical/knative-operators that referenced this issue Dec 10, 2024
orfeas-k added a commit to canonical/kubeflow-profiles-operator that referenced this issue Dec 10, 2024
orfeas-k added a commit to canonical/metacontroller-operator that referenced this issue Dec 10, 2024
orfeas-k added a commit to canonical/namespace-node-affinity-operator that referenced this issue Dec 10, 2024
@orfeas-k
Copy link
Contributor Author

Closed by linked PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant