Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use router #16

Open
vict0rsch opened this issue Sep 25, 2019 · 4 comments
Open

Use router #16

vict0rsch opened this issue Sep 25, 2019 · 4 comments

Comments

@vict0rsch
Copy link
Contributor

We need to have a history in the navigation, maybe reactrouterv4?

@notoraptor
Copy link
Contributor

Hi @vict0rsch !

We initially used react-router on ClimatePixWeb, but we ultimately dropped it because it is not well exported in production, as it creates links that cannot be directly reached. Cf. original issue here: cc-ai/ClimatePixWeb#5

For example, router may allow us to have a link like climatechangeai.org/contact, but this link will work only if reached from home page. If anyone enters this link into a browser address bar and tries to load it, one won't find anything except a 404 error page.

So, I think we should not use react router.

If we really need to handle page links, then I can search if there is a way to handle that with React (though it won't be with Router, anyway, I think), but it may take some time for me to do that.

@vict0rsch
Copy link
Contributor Author

react-router can absolutely handle this, I've used if myself, it works as expected. We can have a look at it together if you want

@notoraptor
Copy link
Contributor

Ah, ok ! Yes, if you use it, can you show me how it works ?

@vict0rsch
Copy link
Contributor Author

Yeah when can we meet for 30 min?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants