Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERS IM packet parsing ignores sample flags and activity task bytes #37

Open
kautlenbachs opened this issue Mar 8, 2024 · 0 comments
Open
Labels
invalid This doesn't seem right

Comments

@kautlenbachs
Copy link
Member

image

Excerpt from code, they are not used.
During the testing this did not trigger, but the echo invalid bit was always '0'

if (!(echo_meta.sample_flags & 0x50) || echo_meta.activity_task != 0xAA) {
            LOGW << "Sample flag not set but transferring data.";
        }
@kautlenbachs kautlenbachs added the invalid This doesn't seem right label Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant