Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use $CXX env variable when available for determining multiarch #125

Open
johnwason opened this issue May 30, 2021 · 1 comment
Open

Use $CXX env variable when available for determining multiarch #125

johnwason opened this issue May 30, 2021 · 1 comment

Comments

@johnwason
Copy link

The function get_multiarch() calls gcc using subprocess. gcc is hard coded, and does not check the CXX env variable. This breaks a lot of build environments, including conda-smithy which uses prefixed gcc executable, and sets CXX to the correct location. This will also break cross compilers that use prefixes.

output = subprocess.check_output(['gcc', '-print-multiarch'])

@cottsay
Copy link
Member

cottsay commented Mar 3, 2022

Using the CXX variable seems reasonable to me, especially in the context of CMake, which also uses that variable.

Please consider opening a PR to change the referenced code to use CXX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants