From 8c86bd94d6eb2f3e3511b8ceb094bb5322b812e2 Mon Sep 17 00:00:00 2001 From: Dave Pearson Date: Mon, 27 Jan 2025 16:37:38 +0000 Subject: [PATCH 1/3] :bug: Temporarily disable editing image Raindrops See #123. --- ChangeLog.md | 2 ++ src/braindrop/app/screens/main.py | 13 +++++++++++++ 2 files changed, 15 insertions(+) diff --git a/ChangeLog.md b/ChangeLog.md index f5435fd..a188ab3 100644 --- a/ChangeLog.md +++ b/ChangeLog.md @@ -11,6 +11,8 @@ - Fixed focus getting lost for a moment if it was within the details panel and the details panel was closed. ([#114](https://github.com/davep/braindrop/issues/114)) +- Temporarily disabled the ability to edit a Raindrop that is an uploaded + image type. ([#123](https://github.com/davep/braindrop/issues/123)) ## v0.6.1 diff --git a/src/braindrop/app/screens/main.py b/src/braindrop/app/screens/main.py index 340a3cc..dbe9251 100644 --- a/src/braindrop/app/screens/main.py +++ b/src/braindrop/app/screens/main.py @@ -672,6 +672,19 @@ async def action_edit_raindrop_command(self) -> None: if (raindrop := self._current_raindrop("edit")) is None: return + # For the moment, don't allow editing of uploaded images. + # https://github.com/davep/braindrop/issues/123 + if raindrop.type == "image": + self.notify( + "Editing of Raindrops that are images can cause the image to be lost. " + "While I investigate why this is I'm disabling the editing of any " + "Raindrop that is an image type.", + title="Editing if images is disabled", + severity="warning", + timeout=8, + ) + return + # If we've got a draft, and it's for the current raindrop... if ( self._draft_raindrop is not None From 72d4ed83716e0063ee6d5ca236ef43a0454161f0 Mon Sep 17 00:00:00 2001 From: Dave Pearson Date: Mon, 27 Jan 2025 16:41:12 +0000 Subject: [PATCH 2/3] :books: Link the ChangeLog to the PR --- ChangeLog.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ChangeLog.md b/ChangeLog.md index a188ab3..6961b87 100644 --- a/ChangeLog.md +++ b/ChangeLog.md @@ -12,7 +12,8 @@ and the details panel was closed. ([#114](https://github.com/davep/braindrop/issues/114)) - Temporarily disabled the ability to edit a Raindrop that is an uploaded - image type. ([#123](https://github.com/davep/braindrop/issues/123)) + image type. ([#123](https://github.com/davep/braindrop/pull/124) i support + of [#123](https://github.com/davep/braindrop/issues/123)) ## v0.6.1 From 682f10cff94263b04031e222dc7fdeaed6075bc5 Mon Sep 17 00:00:00 2001 From: Dave Pearson Date: Mon, 27 Jan 2025 16:42:09 +0000 Subject: [PATCH 3/3] :pencil: Fix a typo --- ChangeLog.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ChangeLog.md b/ChangeLog.md index 6961b87..dae683f 100644 --- a/ChangeLog.md +++ b/ChangeLog.md @@ -12,8 +12,8 @@ and the details panel was closed. ([#114](https://github.com/davep/braindrop/issues/114)) - Temporarily disabled the ability to edit a Raindrop that is an uploaded - image type. ([#123](https://github.com/davep/braindrop/pull/124) i support - of [#123](https://github.com/davep/braindrop/issues/123)) + image type. ([#123](https://github.com/davep/braindrop/pull/124) in + support of [#123](https://github.com/davep/braindrop/issues/123)) ## v0.6.1