Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing a Raindrop that is an uploaded file causes the file to be lost #123

Open
davep opened this issue Jan 27, 2025 · 1 comment
Open
Assignees
Labels
Bug Something isn't working Priority: High I really want to get to this right away (ish) Raindrop Feature A feature of Raindrop that I want to support

Comments

@davep
Copy link
Owner

davep commented Jan 27, 2025

If I edit a Raindrop that is an uploaded image, perhaps to modify the title or tags, this results in the image being lost, with any visit to that image resulting in a "Server Error" from raindrop.io.

I don't know at the moment if this is an API issue, a misuse of the API issue on my part, or something else.

One of two things should happen with this:

  1. See if there's a simple issue in my use of the API and check if I can actually safely edit an image Raindrop without this happening.
  2. If I can't get to the bottom of the above -- or perhaps even before I really dive into this -- perhaps simply disallow editing image Raindrops in Braindrop; so when the user tries to edit a dialog box will pop up and say it's not permitted and why.
@davep davep added Bug Something isn't working Priority: High I really want to get to this right away (ish) Raindrop Feature A feature of Raindrop that I want to support labels Jan 27, 2025
@davep davep self-assigned this Jan 27, 2025
davep added a commit that referenced this issue Jan 27, 2025
davep added a commit that referenced this issue Jan 28, 2025
@davep davep changed the title Editing a Raindrop that is an uploaded image causes the image to be lost Editing a Raindrop that is an uploaded file causes the file to be lost Jan 28, 2025
@davep
Copy link
Owner Author

davep commented Jan 28, 2025

After a bit more evaluation it would appear that this affects any Raindrop that was a file that was uploaded to Raindrop, via the app or the website. I've now tweaked Braindrop so that it refuses to perform an edit on any Raindrop that has a domain property that equals up.raindrop.io.

What is interesting is that if I do such an upload, then edit via the API, the domain property of the Raindrop becomes api.raindrop.io -- this isn't coming from Braindrop; this is what's given back to me post-edit.

At the moment I'm still undecided if it's something I'm doing wrong when doing the update or if it's a genuine bug in their public API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Priority: High I really want to get to this right away (ish) Raindrop Feature A feature of Raindrop that I want to support
Projects
None yet
Development

No branches or pull requests

1 participant