[Bug]: Plugin Icon Management finds non-icon files

[Vodhin]

What e107 version are you using?

v2.3.3

Bug description

It appears that the Plugin Install function finds and logs any file ending in xxx16.png, xxx32.png, xxx48.png, xxx64.png as icons in the Media Manager when the plugin is installed, even if these images are not icons. The problem rears it's head when you go to uninstall the plugin and the system wants to (by default) delete your "icons" including images files that might be needed for a re-install. In my case I have some demo images in a subfolder called "estate/images" needed by the plugin's help section that happen to be demo016.png, demo032.png etc. (my icons are in a folder called "estate/icons"). I have worked around this glitch by changing the file names, but it might be better if the Plugin Management stuck to the files defined in the plugin.xml file.

How to reproduce

Make a plugin with your normal icons in one folder (and define them as icons in plugin.xml) and some images whose names end in 16.png, 32.png, 48.png, and 64.png and include them in another folder. Install and uninstall the plugin. The uninstall (for me) shows the non-icons as "Icons to Delete"

Expected behavior

Not delete non-icon images that happen to have file names that end in 16.png, 32.png etc.

What browser(s) are you seeing the problem on?

Chrome / Brave

PHP Version

8.2.2