Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insphpect results #4

Open
HenkPoley opened this issue Jul 21, 2020 · 1 comment
Open

Insphpect results #4

HenkPoley opened this issue Jul 21, 2020 · 1 comment

Comments

@HenkPoley
Copy link

HenkPoley commented Jul 21, 2020 •
edited
Loading

https://insphpect.com/report/5f168d883467d

I just randomly chose a PHP project from my main Github page. Happened to be this one 🤷‍♂️

The tool seems to mope about usage of new Unit() in Islambey\RSMQ\RSMQ. After careful inspection, all the 'utils' could be static functions. There is not state (no $this) in Islambey\RSMQ\Util. Maybe use them like that?

Edit: What do you know. It will also tell you not to use static functions. Example
@eislambey
Copy link
Owner

Yes, the Util class functions can be static. But you are saying this is bad to.
Maybe we can have pure functions or we can inject Util class but this will be BC break. What is your opinion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@HenkPoley @eislambey