Skip to content
This repository has been archived by the owner on Jan 7, 2024. It is now read-only.

Change the way option param works #4

Open
francisbarton opened this issue Feb 2, 2022 · 0 comments
Open

Change the way option param works #4

francisbarton opened this issue Feb 2, 2022 · 0 comments
Assignees
Labels
bounder To do with refactor of pkg

Comments

@francisbarton
Copy link
Owner

Instead of supplying option = 1 as default, use NULL as default.
Then if user supplies option, we can dispense with the feedback about which dataset is being used for the lookup/bounds. And we can still use if/else to supply option 1 as a default, with the feedback, if option remains NULL.
This will help make output less messy when user is sure which option they want (a bit like readr::read_csv() is quiet if you tell it what col_types to expect, but gives you a load of feedback about what it's doing, if you don't).

@francisbarton francisbarton added the bounder To do with refactor of pkg label Feb 2, 2022
@francisbarton francisbarton self-assigned this Feb 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bounder To do with refactor of pkg
Projects
None yet
Development

No branches or pull requests

1 participant