Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MigrationMap unused? #8

Open
jouke opened this issue Aug 22, 2016 · 2 comments
Open

MigrationMap unused? #8

jouke opened this issue Aug 22, 2016 · 2 comments

Comments

@jouke
Copy link

jouke commented Aug 22, 2016

While working on the pull request I just submitted, I noticed that the MigrationMap model seems unused. Apart from the index.js defining the model and the files that define the model, there is absolutely no reference to it.

Can it be removed? I'd rather not have unused tables in my database... :)

Cheers,

Jouke

@alireza-ahmadi
Copy link

I also agree with @jouke, MigrationMap seems unused and even it's unit tests are useless. Please let us know if you have not implemented it for a specific reason and it can be removed so we can submit a pull request for that.

Thanks for this useful component and I really appreciate any help you can provide.

@mrfelton
Copy link

mrfelton commented Mar 5, 2017

Hi,
The original purpose of the MigrationMap collection was to enable you to store mappings between Object Ids pre and post migration which can be useful if you are migrating data from one system to another where Object Ids are being changed along the way. Arguably this is only useful for certain types of migrations and there are no useful tests for it.

I would consider a pull request that either adds a setting to make the creation of this model optional, or remove it completely from the component.

alireza-ahmadi added a commit to alireza-ahmadi/loopback-component-migrate that referenced this issue Mar 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants