Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New GAN (Hifi-gan replacement) #28

Open
litsa-the-dancer opened this issue Jun 10, 2024 · 6 comments
Open

New GAN (Hifi-gan replacement) #28

litsa-the-dancer opened this issue Jun 10, 2024 · 6 comments
Labels
delayed The priority is a little bit lower enhancement New feature or request help wanted Extra attention is needed

Comments

@litsa-the-dancer
Copy link

Since hifi-gan is really old and outdated, i suggest you add something newer and more robust such as BIGvae gan. The results seem promising and can improve the overall performance of the model and potentially help with stuff such as mode collapse and noise handling. All in all, it's about time RVC gets a newer and more efficient GAN. ^w^

@fumiama fumiama added enhancement New feature or request help wanted Extra attention is needed labels Jun 11, 2024
@fumiama
Copy link
Owner

fumiama commented Jun 11, 2024

Thanks for your advice. I will start doing this after the code being refactored into a programmer-friendly style. Anyone who has interest can also help us by mentioning good algorithms or open PRs.

@blaisewf
Copy link
Contributor

I don't think that the change to other gans will generate a substantial change in quality, the current quality of RVC is quite good, where I think there is potential is mainly in the optimization of the new architectures

@fumiama
Copy link
Owner

fumiama commented Jun 13, 2024

I don't think that the change to other gans will generate a substantial change in quality

Yes, the hifigan in RVC is modified so it has already been bound in the algorithm.

where I think there is potential is mainly in the optimization of the new architectures

Yes, I will do this first. This issue will be considered lastly.

@fumiama fumiama added the delayed The priority is a little bit lower label Jun 13, 2024
@GabryB03
Copy link

GabryB03 commented Jun 19, 2024

Applio developers are already implementing RVC v3 with BIGVGAN as an experiment in their repository:

https://github.com/IAHispano/Applio/tree/exp-bigvgan

I think we can contribute to that or merge in this repository the changes that they're doing. Idk if the devs here want to contribute with blaise-tk (developer of Applio).

@fumiama @alexlnkp

@blaisewf
Copy link
Contributor

Applio developers are already implementing RVC v3 with BIGVGAN as an experiment in their repository:

https://github.com/IAHispano/Applio/tree/exp-bigvgan

I think we can contribute to that or merge in this repository the changes that they're doing. Idk if the devs here want to contribute with blaise-tk (developer of Applio).

@fumiama @alexlnkp

currently it is a bit broken

@fumiama
Copy link
Owner

fumiama commented Jun 21, 2024

I will continue refacturing this repo first. After that, I will consider algorithm improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delayed The priority is a little bit lower enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants