Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplication of dependencies #3

Open
RPDeshaies opened this issue Nov 6, 2017 · 4 comments
Open

Duplication of dependencies #3

RPDeshaies opened this issue Nov 6, 2017 · 4 comments

Comments

@RPDeshaies
Copy link

RPDeshaies commented Nov 6, 2017

In the README, it says

  .instructions("> index.ts")
Notice the > arithmatic symbol above? it is important to make fuse expose your exports.

Isn't that going to duplicate all the dependencies inside the package ?

So if your application and one of your dependency is using lodash, it's going to be included twice in your project since your dependency was built by Fusebox?

@RPDeshaies
Copy link
Author

As another example, I just created a npm package that contains a bunch of reusable React components, but because of this, React and ReactDOM are included twice in my project which causes a bunch of errors at run time

Error: Unable to find node on an unmounted component.

Note: I say that this error is linked to including ReactDOM twice because of this:

Pomax/react-onclickoutside#231 (comment)

@nchanged
Copy link
Contributor

@RPDeshaies use the latest FuseBox, it will get TypeScript source instead of a bundle. And then all of your issues will be resolved

@RPDeshaies
Copy link
Author

2.4.0 ?

@nchanged
Copy link
Contributor

fuse-box@3.0.0-next.26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants